Skip to content

feat(cli): support per-workflow deletion dependencies in transcend.yml - #402

Merged
iamtheluckyest merged 3 commits into
mainfrom
annalisa/wal-10452-push-per-workflow-deletion-dependencies
Aug 17, 2026
Merged

feat(cli): support per-workflow deletion dependencies in transcend.yml#402
iamtheluckyest merged 3 commits into
mainfrom
annalisa/wal-10452-push-per-workflow-deletion-dependencies

Conversation

@iamtheluckyest

@iamtheluckyest iamtheluckyest commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part 1 of 2 for WAL-10452. Part 2 adds the pull side and is stacked on this branch.

What

deletion-dependencies is either a list of titles (global config only) or a list of objects (required once any per-workflow override is present). Mixing titles and objects in the same list is not allowed.

Global only:

deletion-dependencies:
  - Identity Service
  - CRM Warehouse

With overrides (whole list is objects; global becomes { titles }):

deletion-dependencies:
  - titles: [Identity Service]       # global
  - workflow: GDPR Erasure           # override for one workflow
    titles: [Identity Service, CRM Warehouse]
  - workflow: CCPA Delete
    titles: []                       # explicit empty override
  - workflow: Legacy Erasure
    reset-to-global: true            # remove the override

A workflow that isn't listed keeps whatever it already has, so pushing a global-only config never silently wipes overrides.

Blocked on

Do not merge before https://github.com/transcend-io/main/pull/46818 deploys. Push now sends dependedOnDataSilos instead of the deprecated dependedOnDataSiloTitles, and that input field is not on staging yet, so merging early would break transcend inventory push for anyone using deletion dependencies at all.

Notes

  • syncDataSiloDependencies changes signature, hence the major bump on the SDK changeset.
  • workflow maps to workflowConfigInternalName, so no ID lookup is needed on push.
  • The JSON schema files are regenerated from the codec.

Test plan

  • pnpm run --dir packages/cli test
  • pnpm run --dir packages/sdk test
  • Typecheck and build both packages
  • Push a config with a workflow override once #46818 is on staging

Made with Cursor

@iamtheluckyest
feat(cli): support per-workflow deletion dependencies in transcend.yml
8108ceb 
Entries under `deletion-dependencies` may now carry an optional `workflow`
to override the global configuration for a single erasure workflow, or
`reset-to-global: true` to drop an override. Bare title strings still work.

Pushes through the `dependedOnDataSilos` mutation input instead of the
deprecated `dependedOnDataSiloTitles`.
@linear-code

linear-code Bot commented Aug 11, 2026

Copy link
Copy Markdown

WAL-10452

@pkg-pr-new

pkg-pr-new Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@transcend-io/airgap.js-types

pnpm add https://pkg.pr.new/@transcend-io/airgap.js-types@402

yarn add https://pkg.pr.new/@transcend-io/airgap.js-types@402.tgz

@transcend-io/cli

pnpm add https://pkg.pr.new/@transcend-io/cli@402

yarn add https://pkg.pr.new/@transcend-io/cli@402.tgz

@transcend-io/design-tokens

pnpm add https://pkg.pr.new/@transcend-io/design-tokens@402

yarn add https://pkg.pr.new/@transcend-io/design-tokens@402.tgz

@transcend-io/internationalization

pnpm add https://pkg.pr.new/@transcend-io/internationalization@402

yarn add https://pkg.pr.new/@transcend-io/internationalization@402.tgz

@transcend-io/privacy-types

pnpm add https://pkg.pr.new/@transcend-io/privacy-types@402

yarn add https://pkg.pr.new/@transcend-io/privacy-types@402.tgz

@transcend-io/sdk

pnpm add https://pkg.pr.new/@transcend-io/sdk@402

yarn add https://pkg.pr.new/@transcend-io/sdk@402.tgz

@transcend-io/type-utils

pnpm add https://pkg.pr.new/@transcend-io/type-utils@402

yarn add https://pkg.pr.new/@transcend-io/type-utils@402.tgz

@transcend-io/utils

pnpm add https://pkg.pr.new/@transcend-io/utils@402

yarn add https://pkg.pr.new/@transcend-io/utils@402.tgz

@transcend-io/mcp

pnpm add https://pkg.pr.new/@transcend-io/mcp@402

yarn add https://pkg.pr.new/@transcend-io/mcp@402.tgz

@transcend-io/mcp-server-admin

pnpm add https://pkg.pr.new/@transcend-io/mcp-server-admin@402

yarn add https://pkg.pr.new/@transcend-io/mcp-server-admin@402.tgz

@transcend-io/mcp-server-assessment

pnpm add https://pkg.pr.new/@transcend-io/mcp-server-assessment@402

yarn add https://pkg.pr.new/@transcend-io/mcp-server-assessment@402.tgz

@transcend-io/mcp-server-base

pnpm add https://pkg.pr.new/@transcend-io/mcp-server-base@402

yarn add https://pkg.pr.new/@transcend-io/mcp-server-base@402.tgz

@transcend-io/mcp-server-consent

pnpm add https://pkg.pr.new/@transcend-io/mcp-server-consent@402

yarn add https://pkg.pr.new/@transcend-io/mcp-server-consent@402.tgz

@transcend-io/mcp-server-discovery

pnpm add https://pkg.pr.new/@transcend-io/mcp-server-discovery@402

yarn add https://pkg.pr.new/@transcend-io/mcp-server-discovery@402.tgz

@transcend-io/mcp-server-docs

pnpm add https://pkg.pr.new/@transcend-io/mcp-server-docs@402

yarn add https://pkg.pr.new/@transcend-io/mcp-server-docs@402.tgz

@transcend-io/mcp-server-dsr

pnpm add https://pkg.pr.new/@transcend-io/mcp-server-dsr@402

yarn add https://pkg.pr.new/@transcend-io/mcp-server-dsr@402.tgz

@transcend-io/mcp-server-inventory

pnpm add https://pkg.pr.new/@transcend-io/mcp-server-inventory@402

yarn add https://pkg.pr.new/@transcend-io/mcp-server-inventory@402.tgz

@transcend-io/mcp-server-preferences

pnpm add https://pkg.pr.new/@transcend-io/mcp-server-preferences@402

yarn add https://pkg.pr.new/@transcend-io/mcp-server-preferences@402.tgz

@transcend-io/mcp-server-workflows

pnpm add https://pkg.pr.new/@transcend-io/mcp-server-workflows@402

yarn add https://pkg.pr.new/@transcend-io/mcp-server-workflows@402.tgz

commit: aab1463

iamtheluckyest
iamtheluckyest commented Aug 11, 2026
View reviewed changes
Comment thread packages/cli/src/lib/graphql/normalizeDeletionDependencies.ts Outdated
@iamtheluckyest iamtheluckyest mentioned this pull request Aug 11, 2026
Open
4 tasks
iamtheluckyest
iamtheluckyest commented Aug 11, 2026
View reviewed changes
Comment thread packages/cli/src/lib/graphql/normalizeDeletionDependencies.ts Outdated
iamtheluckyest
iamtheluckyest commented Aug 11, 2026
View reviewed changes
Comment thread packages/cli/src/codecs.ts Outdated
@iamtheluckyest
refactor(cli): require either string[] or object[] for deletion-depen…
391ece7 
…dencies

Reject mixed lists so global-only configs stay as title strings, while any
per-workflow override uses a full object list including global `{ titles }`.
iamtheluckyest
iamtheluckyest commented Aug 11, 2026
View reviewed changes
Comment thread packages/cli/src/codecs.ts Outdated
iamtheluckyest
iamtheluckyest commented Aug 11, 2026
View reviewed changes
Comment thread packages/cli/src/codecs.ts Outdated
@iamtheluckyest
iamtheluckyest requested a review from a team August 11, 2026 12:28
@iamtheluckyest
iamtheluckyest marked this pull request as ready for review August 11, 2026 12:28
iamtheluckyest
iamtheluckyest commented Aug 11, 2026
View reviewed changes
Comment thread packages/cli/src/lib/graphql/normalizeDeletionDependencies.ts Outdated
iamtheluckyest
iamtheluckyest commented Aug 11, 2026
View reviewed changes
Comment thread packages/cli/README.md Outdated

When an erasure request runs, `deletion-dependencies` holds off deleting from a data silo until the data silos it lists have finished deleting.

Use a list of titles when there are no per-workflow overrides:

@iamtheluckyest iamtheluckyest Aug 11, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we note this as deprecated? Follow other examples in the README for deprecated fields. If there are none, let me know.

iamtheluckyest
iamtheluckyest commented Aug 11, 2026
View reviewed changes
Comment thread packages/cli/README.md Outdated
iamtheluckyest
iamtheluckyest commented Aug 11, 2026
View reviewed changes
Comment thread packages/cli/README.md

A workflow that is not listed keeps whatever configuration it already has, so pushing a config that only lists global dependencies never removes existing overrides. Use `reset-to-global: true` to remove one.

Omitting `deletion-dependencies` entirely clears the global configuration, matching how the rest of `transcend.yml` treats omitted fields.

@iamtheluckyest iamtheluckyest Aug 11, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Not for reviewers, not for Cursor] Even though it says this matches "how the rest of transcend.yml treats omitted fields" this does not seem like obvious behavior to me. If we do want to do it this way, I'm not sure that justifying it by saying "matching how the rest of transcend.yml treats omitted fields." is appropriate within the README.

iamtheluckyest
iamtheluckyest commented Aug 11, 2026
View reviewed changes
Comment thread packages/cli/src/lib/tests/normalizeDeletionDependencies.test.ts Outdated
iamtheluckyest
iamtheluckyest commented Aug 11, 2026
View reviewed changes
Comment thread packages/cli/src/lib/tests/normalizeDeletionDependencies.test.ts Outdated
michaelfarrell76
michaelfarrell76 approved these changes Aug 11, 2026
View reviewed changes

@michaelfarrell76 michaelfarrell76 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

jefgodesky
jefgodesky reviewed Aug 12, 2026
View reviewed changes

@jefgodesky jefgodesky left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems well-aligned at the product level, and the code LGTM, but I'll defer to @mason-hale for a proper, Waluigi-internal technical review.

@jefgodesky
jefgodesky requested a review from mason-hale August 12, 2026 19:50
mason-hale
mason-hale reviewed Aug 12, 2026
View reviewed changes
Comment thread packages/cli/src/lib/graphql/normalizeDeletionDependencies.ts
mason-hale
mason-hale reviewed Aug 12, 2026
View reviewed changes
Comment thread packages/cli/src/lib/graphql/normalizeDeletionDependencies.ts
mason-hale
mason-hale approved these changes Aug 12, 2026
View reviewed changes

@mason-hale mason-hale left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@iamtheluckyest
iamtheluckyest added this pull request to the merge queue Aug 17, 2026
Merged via the queue into main with commit 43d6ffe Aug 17, 2026
4 checks passed
@iamtheluckyest
iamtheluckyest deleted the annalisa/wal-10452-push-per-workflow-deletion-dependencies branch August 17, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jefgodesky jefgodesky jefgodesky left review comments
@mason-hale mason-hale mason-hale approved these changes
@michaelfarrell76 michaelfarrell76 michaelfarrell76 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iamtheluckyest @jefgodesky @mason-hale @michaelfarrell76